fix build time_t for 32-bits#78
Open
andypost wants to merge 2 commits into
Open
Conversation
andypost
force-pushed
the
63-fix-32-bits-build
branch
from
c167636 to
2b897a4
Compare
andypost
commented
Oct 27, 2024
| #include "pool_parser.h" | ||
| #include "stringinfo.h" | ||
| #include "utils/palloc.h" | ||
| #include "postgresql/16/server/postgres_fe.h" |
Author
There was a problem hiding this comment.
it brings warning and is not good approach
gcc -DHAVE_CONFIG_H -I. -I../../src/include -D_GNU_SOURCE -I ../../src/include/parser -I /usr/include/postgresql -Os -fstack-clash-protection -Wformat -Werror=format-security -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-format-truncation -Wno-stringop-truncation -fno-strict-aliasing -c -o snprintf.o snprintf.c
snprintf.c:79:9: warning: "MemSet" redefined
79 | #define MemSet(start, val, len) \
| ^~~~~~
In file included from /usr/include/postgresql/16/server/postgres_fe.h:25,
from snprintf.c:50:
/usr/include/postgresql/16/server/c.h:1004:9: note: this is the location of the previous definition
1004 | #define MemSet(start, val, len) \
| ^~~~~~
rm -f libsql-parser.a
|
@tatsuo-ishii, we use this patch in the pgpool package in Alpine Linux for almost two years. Now I’m updating the package to 4.7 and it doesn’t apply anymore, so I have to rework it. Can you please review it and merge it, or tell us why you don’t want to? |
Collaborator
|
We don't accept GitHub pull requests. Can you please post patches to pgpool-hackers mailing list? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added fix from #63 (comment)